fix(Shield): remove Unknown question mark icon #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastilian
reviewed
Jan 22, 2025
| @@ -22,7 +21,12 @@ const Shield: React.FunctionComponent<ShieldProps> = ({ impact = 'N/A', hasLabel | |||
| color: attributes.color, | |||
| }; | |||
|
|
|||
| const badge = <Icon size={size}>{attributes.title === 'Unknown' ? <QuestionIcon {...badgeProps} /> : <SecurityIcon {...badgeProps} />}</Icon>; | |||
There was a problem hiding this comment.
We might want to add a prop to show an icon and which icon, since there might be places where we actually do want to show an icon.
The default behaviour should still remain the same.
xmicha82
force-pushed
the
rm-unknown-icon
branch
from
9db2826 to
970c91d
Compare
johnsonm325
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Please update the documentation for this component as well: https://github.com/RedHatInsights/frontend-components/blob/master/packages/components/doc/shield.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed QuestionIcon from Shield component as per RHINENG-12939