fix(floorist): RHICOMPL-2984 Bugfix for empty prefix floorplan #29
Conversation
Victoremepunto
commented
May 24, 2022
•
Victoremepunto
commented
- Fix a bug for when floorplan file does not provide prefix
- Add helper function for generating directory names
- Add helper function for validating Floorplan files
- Add unit test coverage
Victoremepunto
force-pushed
the
empty-prefix-is-not-handled
branch
from
01e2279 to
1d3d282
Compare
Victoremepunto
changed the title
Victoremepunto
force-pushed
the
empty-prefix-is-not-handled
branch
2 times, most recently
from
6dd9d5e to
4cd5c78
Compare
Victoremepunto
force-pushed
the
empty-prefix-is-not-handled
branch
4 times, most recently
from
a0049ab to
f028b1c
Compare
- Fix a bug for when floorplan file does not provide prefix - Add helper function for generating directory names - Add helper function for validating Floorplan files - Add unit test coverage
Victoremepunto
force-pushed
the
empty-prefix-is-not-handled
branch
from
f028b1c to
1dc01c9
Compare
|
@Victoremepunto the PR is providing a bit more than it was described in the epic. Can we reduce it to a minimal solution and extract & discuss the unit testing + refactoring in a separate ticket please? |
@skateman what is the minimal part you'd like to see out of it ? I created the tests before the feature was implemented and I see them as a whole. What is being added is:
|
|
I am still conservative about unit tests here and it feels like you're doing the refactor in order to be able to do unit tests. The scope of the project is still small enough to have just high-level tests and as long as it is so, I would like to keep it like this. Again, in case of a go-reimplementation we can just drop-in replace the main() calls in these. |
Yes, exactly. I had to refactor because the way it is implemented is impossible to test. I don't think that's a desirable situation and decided to fix it. Please, suggest the next course of action |
