Handle service accounts #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehort
force-pushed
the
handle_service_accounts
branch
from
811d56e to
46bfa30
Compare
dehort
commented
Jan 25, 2024
middleware/user.go
Outdated
| if id.Identity.Type != "User" { | ||
| username = id.Identity.User.Username | ||
| } else if id.Identity.Type != "ServiceAccount" { | ||
| if id.Identity.ServiceAccount == nil { |
There was a problem hiding this comment.
Gotta watch out for the null pointer here. hmm...
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 45.08% 45.72% +0.63%
==========================================
Files 18 18
Lines 1313 1334 +21
==========================================
+ Hits 592 610 +18
- Misses 680 682 +2
- Partials 41 42 +1 ☔ View full report in Codecov by Sentry. |
tahmidefaz
previously approved these changes
Jan 30, 2024
dehort
force-pushed
the
handle_service_accounts
branch
from
f3b2072 to
aa4429e
Compare
dehort
force-pushed
the
handle_service_accounts
branch
from
289a022 to
b80e76a
Compare
|
I'm going to get PR#128 merged in first, then rebase this one to include PR#128. |
Moving to platform-go-middlewares v2 Moving to golang 1.20
dehort
force-pushed
the
handle_service_accounts
branch
from
b80e76a to
4e36823
Compare
tahmidefaz
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Moved to platform-go-middlewares v2
Modified the middlewares to accept a service-account
Why?
Add support for service-accounts
Testing
Added service-account tests to user middleware
Anything Else?
Any other notes about the PR that would be useful for the reviewer.
Secure Coding Practices Checklist Link
Secure Coding Checklist