Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of Empty State inside a table (mobile) #1279

Closed

Conversation

epwinchell
Copy link

@epwinchell epwinchell commented Jun 9, 2021

Jira: https://issues.redhat.com/browse/RHCLOUD-10266
Relates to: RedHatInsights/frontend-components#1167

Old
Screen Shot 2021-06-09 at 3 32 32 PM

New
Screen Shot 2021-06-09 at 3 30 58 PM

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@epwinchell epwinchell marked this pull request as draft June 9, 2021 19:36
@epwinchell epwinchell force-pushed the empty_state_in_table_fix branch from ef70046 to e0b9f92 Compare June 9, 2021 19:43
@epwinchell epwinchell force-pushed the empty_state_in_table_fix branch from e0b9f92 to 7f0caf4 Compare June 9, 2021 19:51
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

Merging #1279 (34d18f6) into master (d2aace5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 34d18f6 differs from pull request most recent head 6310528. Consider uploading reports for the commit 6310528 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   74.09%   74.10%   +0.01%     
==========================================
  Files         118      118              
  Lines        2208     2209       +1     
  Branches      559      560       +1     
==========================================
+ Hits         1636     1637       +1     
  Misses        488      488              
  Partials       84       84              
Impacted Files Coverage Δ
...ntationalComponents/PoliciesTable/PoliciesTable.js 75.43% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2aace5...6310528. Read the comment docs.

@bastilian
Copy link
Member

Thank you for fixing this and making sure apps are updated, however this seems to be an issue in Patternfly. There is an issue[0] and and PR[1] with a potential fix. I'd rather prefer to wait for the fix in Patternfly and avoid having to remove this bit in the future.

[0] patternfly/patternfly-react#5379
[1] patternfly/patternfly-react#5886

@epwinchell epwinchell closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants