-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image builder helper tools #22
Add image builder helper tools #22
Conversation
d21e03b
to
1c4881f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid changes, great work! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted a couple minor things, mostly looks good, I think it will mostly come down to testing everything well :)
Only thing I will add is that I think each library/module should have documentation in the README (or in another .md
file) that lists which env vars can be set for the library by the caller, what the defaults are if they are unset, and what each env var controls... but that can be done in a follow-up PR.
ddd4a3b
to
8d5dc07
Compare
Add
image_builder
module, providesThis also adds a refactor for
common
andcore
functions to log error and debug messages, as well as a refactor of file names and variables to confort to a naming convention.