Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image builder helper tools #22

Merged
merged 39 commits into from
Sep 29, 2023

Conversation

Victoremepunto
Copy link
Contributor

@Victoremepunto Victoremepunto commented Sep 14, 2023

Add image_builder module, provides

  • build (for building and tagging images)
  • tag (for tagging images)
  • push (for pushing images and tags)
  • get_image_tag (for calculating appropriate build image_tag depending on context)

This also adds a refactor for common and core functions to log error and debug messages, as well as a refactor of file names and variables to confort to a naming convention.

@Victoremepunto Victoremepunto marked this pull request as ready for review September 14, 2023 19:54
@Victoremepunto Victoremepunto marked this pull request as draft September 14, 2023 19:56
@Victoremepunto Victoremepunto marked this pull request as ready for review September 18, 2023 15:02
@Victoremepunto Victoremepunto changed the title Add build helper tools Add image builder helper tools Sep 19, 2023
Copy link
Contributor

@maknop maknop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid changes, great work! LGTM

src/bootstrap.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@bsquizz bsquizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a couple minor things, mostly looks good, I think it will mostly come down to testing everything well :)

Only thing I will add is that I think each library/module should have documentation in the README (or in another .md file) that lists which env vars can be set for the library by the caller, what the defaults are if they are unset, and what each env var controls... but that can be done in a follow-up PR.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/shared/common_lib.sh Show resolved Hide resolved
src/shared/image_builder_lib.sh Outdated Show resolved Hide resolved
src/shared/image_builder_lib.sh Outdated Show resolved Hide resolved
src/shared/image_builder_lib.sh Outdated Show resolved Hide resolved
src/shared/image_builder_lib.sh Outdated Show resolved Hide resolved
src/shared/image_builder_lib.sh Outdated Show resolved Hide resolved
src/shared/image_builder_lib.sh Outdated Show resolved Hide resolved
@bsquizz bsquizz merged commit 4f68837 into RedHatInsights:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants