-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-5265: Replace edge widget with image builder #749
base: main
Are you sure you want to change the base?
Conversation
Looks like the tests are snapshotting the landing page, we'll need to change those snapshots :) |
Tests are fixed. |
@amirfefer Thanks for doing this. I discussed this PR with UXD. I have a ticket to reorganize the dashboard https://issues.redhat.com/browse/RHCLOUD-32750. We agreed to update the designs and wait until this PR has been merged to proceed. cc @karelhala |
just FYI, this re-organization will only affect new dashboards or users that have "reset" their dashboards. From the looks of it, if the UI code for the edge widget is being removed, and or renamed. If the module for the edge widget is removed from the UI, the dashboard will be in a broken state. Do we need a DB migration to replace the widgets in existing customized dashboards? |
@Hyperkid123, Thank you for the review and for pointing this out. I agree that removing or renaming the edge widget in the UI could lead to a broken state for existing customized dashboards. Once we ensure the new widget is in place and working as expected, we can plan and implement a migration to replace the edge widget in existing customized dashboards. |
@amirfefer yea, that is what we should do for now. |
@amirfefer @epwinchell where are with the widget swap? |
@Hyperkid123, from my side it's all set, verified locally 🟢 |
/retest |
Only Vulnerability scan failed, that looks reasonable to ignore given it's running in Konflux as well and that went green? |
This PR replaces the outdated Edge service widget with a new widget showcasing the "Image Builder" service. The updated widget should provide a clear, concise description of Image Builder's capabilities and include a link for the service.
Before:
![Screenshot 2025-01-07 at 13 36 00](https://private-user-images.githubusercontent.com/11807069/400751167-a0805e14-4a99-4f66-9308-9ac55defc257.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMTQwMTksIm5iZiI6MTczOTMxMzcxOSwicGF0aCI6Ii8xMTgwNzA2OS80MDA3NTExNjctYTA4MDVlMTQtNGE5OS00ZjY2LTkzMDgtOWFjNTVkZWZjMjU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDIyNDE1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWZjMjhjMjcwMjYzNTEyNzlhNDBlNWVlN2RlNjY1MmJlNDA2ZWFlMDE1YmZjZWEwZjJiOWNkOWI1Y2IzNmJiNjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jovq29kfHkC67l69qNXi5br2FVZGUvQbXoxBaq4d3o0)
After:
![Screenshot 2025-01-07 at 12 54 39](https://private-user-images.githubusercontent.com/11807069/400750977-68832a6b-46f2-4497-855f-78f4f8eebd46.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMTQwMTksIm5iZiI6MTczOTMxMzcxOSwicGF0aCI6Ii8xMTgwNzA2OS80MDA3NTA5NzctNjg4MzJhNmItNDZmMi00NDk3LTg1NWYtNzhmNGY4ZWViZDQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDIyNDE1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY0NDdkZGFmYWUxZDc2NTZiZDdhMTQ0NjI1OGQ3OGQxZTA4YjM3YmFiOTAyNGEwYzNlZTY5NmMyYWNkMWE0OTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hxWFxor-uASsu853zxfXTgfFd-zmejBkPa7_B7kFRb4)