Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMS-5265: Replace edge widget with image builder #749

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amirfefer
Copy link
Member

This PR replaces the outdated Edge service widget with a new widget showcasing the "Image Builder" service. The updated widget should provide a clear, concise description of Image Builder's capabilities and include a link for the service.

Before:
Screenshot 2025-01-07 at 13 36 00

After:
Screenshot 2025-01-07 at 12 54 39

@ezr-ondrej
Copy link
Member

Looks like the tests are snapshotting the landing page, we'll need to change those snapshots :)

@amirfefer
Copy link
Member Author

Tests are fixed.

@epwinchell
Copy link
Contributor

epwinchell commented Jan 12, 2025

@amirfefer Thanks for doing this. I discussed this PR with UXD. I have a ticket to reorganize the dashboard https://issues.redhat.com/browse/RHCLOUD-32750. We agreed to update the designs and wait until this PR has been merged to proceed. cc @karelhala

@Hyperkid123
Copy link
Contributor

just FYI, this re-organization will only affect new dashboards or users that have "reset" their dashboards.

From the looks of it, if the UI code for the edge widget is being removed, and or renamed. If the module for the edge widget is removed from the UI, the dashboard will be in a broken state. Do we need a DB migration to replace the widgets in existing customized dashboards?

@amirfefer
Copy link
Member Author

@Hyperkid123, Thank you for the review and for pointing this out. I agree that removing or renaming the edge widget in the UI could lead to a broken state for existing customized dashboards.
My preference would be to first add the new Image Builder widget to the default dashboard layout while keeping the edge widget in custom dashboards for now.

Once we ensure the new widget is in place and working as expected, we can plan and implement a migration to replace the edge widget in existing customized dashboards.

@Hyperkid123
Copy link
Contributor

@amirfefer yea, that is what we should do for now.

@Hyperkid123
Copy link
Contributor

@amirfefer @epwinchell where are with the widget swap?

@amirfefer
Copy link
Member Author

amirfefer commented Feb 11, 2025

@Hyperkid123, from my side it's all set, verified locally 🟢

@ezr-ondrej
Copy link
Member

/retest

@ezr-ondrej
Copy link
Member

Only Vulnerability scan failed, that looks reasonable to ignore given it's running in Konflux as well and that went green?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants