Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move domain allowlist to Auth0 action #657

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

macfarlandian
Copy link
Collaborator

Description of the change

We already had an action that was mostly overlapping with our deprecated hook, so this just adds the missing piece of denying access to signups that don't hit the domain mapping. (The diff is a little misleading, because the domain-mapping solution was already what was live in Auth0; all I did was add the deny call at the end and move recidiviz email domains into the mapping instead of handling them separately.) While in there I reorganized the files a bit to better reflect the Auth0 resources they represent.

All of these changes are already live in staging and the hook has been deleted. You can see evidence of this working in the Auth0 logs: expected success, expected failure

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Configuration change (adjusts configuration to achieve some end related to functionality, development, performance, or security)

Related issues

Closes #656

Checklists

Development

These boxes should be checked by the submitter prior to merging:

  • Manual testing against realistic data has been performed locally

Code review

These boxes should be checked by reviewers prior to merging:

  • This pull request has a descriptive title and information useful to a reviewer
  • This pull request has been moved out of a Draft state, has no "Work In Progress" label, and has assigned reviewers
  • Potential security implications or infrastructural changes have been considered, if relevant

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11061359288

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on ian/656-migrate-hook at 78.516%

Totals Coverage Status
Change from base Build 11060853639: 78.5%
Covered Lines: 2135
Relevant Lines: 2557

💛 - Coveralls

@macfarlandian macfarlandian merged commit 9c4fe3f into main Sep 26, 2024
15 checks passed
@macfarlandian macfarlandian deleted the ian/656-migrate-hook branch September 26, 2024 23:06
@lilidworkin
Copy link
Contributor

Thanks so much, @macfarlandian !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate deprecated Auth0 hook to action
4 participants