[addons][PVR] Fix PVR_TIMER_TYPE::iPreventDuplicateEpisodesDefault an…

…d PVR_TIMER_TYPE::iRecordingGroupDefault type (signed/unsigned mismatch).
Rechi · Dec 21, 2024 · e19f93b · e19f93b
1 parent 22a9ed0
commit e19f93b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 15 deletions.
diff --git a/xbmc/addons/kodi-dev-kit/include/kodi/c-api/addon-instance/pvr/pvr_timers.h b/xbmc/addons/kodi-dev-kit/include/kodi/c-api/addon-instance/pvr/pvr_timers.h
@@ -391,11 +391,11 @@ extern "C"
 
     unsigned int iPreventDuplicateEpisodesSize;
     struct PVR_ATTRIBUTE_INT_VALUE* preventDuplicateEpisodes;
-    unsigned int iPreventDuplicateEpisodesDefault;
+    int iPreventDuplicateEpisodesDefault;
 
     unsigned int iRecordingGroupSize;
     struct PVR_ATTRIBUTE_INT_VALUE* recordingGroup;
-    unsigned int iRecordingGroupDefault;
+    int iRecordingGroupDefault;
 
     unsigned int iMaxRecordingsSize;
     struct PVR_ATTRIBUTE_INT_VALUE* maxRecordings;

diff --git a/xbmc/pvr/settings/PVRIntSettingValues.cpp b/xbmc/pvr/settings/PVRIntSettingValues.cpp
@@ -48,15 +48,6 @@ CPVRIntSettingValues::CPVRIntSettingValues(int defaultValue) : m_defaultValue(de
 {
 }
 
-CPVRIntSettingValues::CPVRIntSettingValues(struct PVR_ATTRIBUTE_INT_VALUE* values,
-                                           unsigned int valuesSize,
-                                           unsigned int defaultValue,
-                                           int defaultDescriptionResourceId /* = 0 */)
-  : CPVRIntSettingValues(
-        values, valuesSize, static_cast<int>(defaultValue), defaultDescriptionResourceId)
-{
-}
-
 CPVRIntSettingValues::CPVRIntSettingValues(const std::vector<SettingIntValue>& values,
                                            int defaultValue)
   : m_values(values), m_defaultValue(defaultValue)

diff --git a/xbmc/pvr/settings/PVRIntSettingValues.h b/xbmc/pvr/settings/PVRIntSettingValues.h
@@ -27,10 +27,6 @@ class CPVRIntSettingValues
                        unsigned int valuesSize,
                        int defaultValue,
                        int defaultDescriptionResourceId = 0);
-  CPVRIntSettingValues(struct PVR_ATTRIBUTE_INT_VALUE* values,
-                       unsigned int valuesSize,
-                       unsigned int defaultValue,
-                       int defaultDescriptionResourceId = 0);
   CPVRIntSettingValues(const std::vector<SettingIntValue>& values, int defaultValue);
 
   virtual ~CPVRIntSettingValues() = default;