Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename orderId to subscriptionId in quotes #1856

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Conversation

lexerom
Copy link
Contributor

@lexerom lexerom commented Apr 3, 2024

Summary

Old orderId can be subscription or one time sale purchase

Links

Checklist

  • Writing style
  • API design standards

@lexerom lexerom self-assigned this Apr 3, 2024
@lexerom lexerom marked this pull request as ready for review April 3, 2024 09:41
@lexerom lexerom requested review from a team as code owners April 3, 2024 09:41
XaosSintez
XaosSintez previously approved these changes Apr 3, 2024
noon-dawg
noon-dawg previously approved these changes Apr 3, 2024
Copy link
Contributor

@noon-dawg noon-dawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the docs side

@lexerom lexerom dismissed stale reviews from noon-dawg and XaosSintez via f010779 April 3, 2024 14:10
@lexerom lexerom merged commit b89fbc9 into main Apr 8, 2024
2 checks passed
@lexerom lexerom deleted the rename-quote-orderId branch April 8, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants