Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source to dispute #1816

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Add source to dispute #1816

merged 2 commits into from
Mar 4, 2024

Conversation

ashkarpetin
Copy link
Contributor

Summary

Add source to dispute

Links

Checklist

  • Writing style
  • API design standards

@ashkarpetin ashkarpetin self-assigned this Feb 29, 2024
ashkarpetin
ashkarpetin commented Feb 29, 2024
View reviewed changes
openapi/components/schemas/Dispute.yaml
- 'null'
readOnly: true
enum:
- null
Copy link
Contributor Author

@ashkarpetin ashkarpetin Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure which would be better: nullable source or make it not nullable with default source unknown

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think null is probably better. For old disputes, it's technically possible to backfill, so "unknown" isn't ideal imo.

@ashkarpetin ashkarpetin marked this pull request as ready for review February 29, 2024 18:03
@ashkarpetin ashkarpetin requested review from a team as code owners February 29, 2024 18:03
@ashkarpetin ashkarpetin merged commit d6882f2 into main Mar 4, 2024
2 checks passed
@ashkarpetin ashkarpetin deleted the add-dispute-source branch March 4, 2024 15:10
@rebilly-machine-user rebilly-machine-user mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XaosSintez XaosSintez XaosSintez approved these changes

@colinbird colinbird colinbird approved these changes

@justnero justnero justnero approved these changes

@vykhrystiuk vykhrystiuk vykhrystiuk approved these changes

@noon-dawg noon-dawg noon-dawg approved these changes

@i-yasko i-yasko i-yasko approved these changes

@VladimirRebilly VladimirRebilly VladimirRebilly approved these changes

Assignees

@ashkarpetin ashkarpetin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ashkarpetin @XaosSintez @colinbird @justnero @vykhrystiuk @noon-dawg @i-yasko @VladimirRebilly