Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add depositRequestId to storefront transaction #1767

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Add depositRequestId to storefront transaction #1767

merged 2 commits into from
Mar 12, 2024

Conversation

colinbird
Copy link
Contributor

@colinbird colinbird commented Jan 31, 2024 •
edited
Loading

Summary

HPF will need the depositRequestId in order to call storefront post deposit on a "retry"

Links

Checklist

  • Writing style
  • API design standards

@colinbird colinbird self-assigned this Jan 31, 2024
@jvc9109 jvc9109 marked this pull request as ready for review March 12, 2024 12:08
@jvc9109 jvc9109 requested review from a team as code owners March 12, 2024 12:08
@jvc9109 jvc9109 merged commit b5bb267 into main Mar 12, 2024
2 checks passed
@jvc9109 jvc9109 deleted the add-storefront-transaction-depositrequestId branch March 12, 2024 14:56
@rebilly-machine-user rebilly-machine-user mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashkarpetin ashkarpetin ashkarpetin approved these changes

@lexerom lexerom lexerom approved these changes

@nanobash nanobash nanobash approved these changes

@noon-dawg noon-dawg noon-dawg approved these changes

Assignees

@colinbird colinbird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@colinbird @ashkarpetin @lexerom @nanobash @noon-dawg @jvc9109