-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add address-based and refactor AML confidence settings #1697
Merged
Merged
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7ea1c6f
Add address-based AML confidence settings
mikerebilly e26aeb6
Update description phrasing
mikerebilly dcc80a7
Update phrasing and key
mikerebilly 92aca15
Merge branch 'main' into add-address-aml-settings
mikerebilly 0b7899e
Change structure
mikerebilly 4fd3861
Restructure entire schema
mikerebilly 20be559
Merge branch 'main' into add-address-aml-settings
mikerebilly f7f68f3
Simplify address matching
mikerebilly feac10d
Update descriptions
mikerebilly c2cb55e
Merge branch 'main' into add-address-aml-settings
mikerebilly d47f59e
FIx descriptions
mikerebilly 329f0c6
Merge branch 'main' into add-address-aml-settings
mikerebilly b52badd
Merge branch 'main' into add-address-aml-settings
mikerebilly 0ba4d1d
Fix new lint rule
mikerebilly b21949d
Merge branch 'main' into add-address-aml-settings
ashkarpetin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
type: object | ||
properties: | ||
addressMatch: | ||
type: object | ||
description: A match for the customer's city or region, or both, is found. | ||
properties: | ||
matchingCountry: | ||
$ref: ./AmlConfidence.yaml | ||
mismatchingCountry: | ||
$ref: ./AmlConfidence.yaml | ||
noCountry: | ||
$ref: ./AmlConfidence.yaml | ||
addressMismatch: | ||
type: object | ||
description: A match for the customer's city or region, or both, is not found. | ||
properties: | ||
matchingCountry: | ||
$ref: ./AmlConfidence.yaml | ||
mismatchingCountry: | ||
$ref: ./AmlConfidence.yaml | ||
noCountry: | ||
$ref: ./AmlConfidence.yaml | ||
noAddress: | ||
type: object | ||
description: No city and no region is available to match against. | ||
properties: | ||
matchingCountry: | ||
$ref: ./AmlConfidence.yaml | ||
mismatchingCountry: | ||
$ref: ./AmlConfidence.yaml | ||
noCountry: | ||
$ref: ./AmlConfidence.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by these property names. How do you find the mismatch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamaltman Most of our records (from sources) populate the country fields with common names, not the ISO standard. So we first see how well a customer's country matches against the database among all other considerations, and then we run binary logic afterward to consider the country a match or not.