Add quote taxes #1635
Merged
Add quote taxes #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noon-dawg
previously approved these changes
Oct 11, 2023
tamasvigh
previously approved these changes
Oct 11, 2023
adamaltman
reviewed
Oct 13, 2023
| readOnly: true | ||
| items: | ||
| type: array | ||
| description: Taxes that are applied to this invoice and calculated based on the `taxCategoryId` of the related product. | ||
| description: Taxes applied and calculated based on the `taxCategoryId` of the related product. | ||
| items: | ||
| allOf: |
adamaltman
reviewed
Oct 13, 2023
| @@ -12,11 +12,11 @@ properties: | |||
| type: integer | |||
| x-type: Money | |||
| x-sortable: true | |||
| description: Total amount of all invoice taxes. | |||
| description: Total amount of all taxes. | |||
There was a problem hiding this comment.
Suggested change
| description: Total amount of all taxes. | |
| description: Total amount of taxes. |
adamaltman
requested changes
Oct 13, 2023
Comment on lines
73
to
75
| description: Invoice taxes. | ||
| allOf: | ||
| - $ref: ./Taxes/Taxes.yaml |
There was a problem hiding this comment.
I would use the description from the Taxes.yaml object everywhere throughout and not try to override the description with allOf.
noon-dawg
previously approved these changes
Oct 16, 2023
adamaltman
requested changes
Oct 16, 2023
| @@ -1,33 +1,33 @@ | |||
| allOf: | |||
| - properties: | |||
| rate: | |||
| readOnly: true | |||
| readOnly: false | |||
There was a problem hiding this comment.
allOf does not override. This is not valid.
adamaltman
approved these changes
Oct 16, 2023
tamasvigh
approved these changes
Oct 17, 2023
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add taxes to Quote, rearrange tax files. So, invoice and quote will have the same tax object (with some readonly properties), CreditMemo will have tax with all writable properties.
Preview
Checklist