Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide meta data to custom merge functions #33

Closed
RebeccaStevens opened this issue Feb 10, 2022 · 3 comments · Fixed by #32 or #29
Closed

Provide meta data to custom merge functions #33

RebeccaStevens opened this issue Feb 10, 2022 · 3 comments · Fixed by #32 or #29
Labels
Resolution: Added This has been added to the project. Status: Released It's now live. Type: Feature New features or options.

Comments

@RebeccaStevens
Copy link
Owner

Suggestion

When merging values, it is not uncommon that meta data is need to know how to merge the values. An example would be that values may want to be merged differently if they are under a certain key on a record.

By default, key meta data should be provided by this library.

Users should also have the ability to control/customize the meta data as the deepmerge function steps through.
An example of customizing the meta data would be to mark a flag at some point through the merge to customize how child elements are then merged. An other example would be to keep track of the full key path travelled by the function.
@RebeccaStevens RebeccaStevens added the Type: Feature New features or options. label Feb 10, 2022
This was referenced Feb 10, 2022
Merged
Closed
@RebeccaStevens RebeccaStevens added the Status: In Progress Issue is currently being resolved by a developer. label Feb 10, 2022
RebeccaStevens added a commit that referenced this issue Feb 13, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
3ecdcec 
…customized

fix #33

BREAKING CHANGE: custom function call signatures have changed
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
cbaa883 
…customized

fix #33

BREAKING CHANGE: custom function call signatures have changed
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
d53d085 
…customized

fix #33

BREAKING CHANGE: custom function call signatures have changed
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
a4bbff0 
…customized

fix #33

BREAKING CHANGE: custom function call signatures have changed
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
9ace3cd 
…customized

fix #33
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
18c05b6 
…customized

fix #33
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
e192118 
…customized

fix #33
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
60be6c2 
…customized

fix #33
RebeccaStevens added a commit that referenced this issue Feb 14, 2022
@RebeccaStevens
feat: provide meta data to custom merge functions and allow it to be …
0cae060 
…customized

fix #33
@RebeccaStevens RebeccaStevens mentioned this issue Feb 14, 2022
Closed
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

RebeccaStevens added a commit that referenced this issue Feb 16, 2022
@RebeccaStevens
feat: provide customizable meta data to custom merge functions
13f1993 
fix #33
RebeccaStevens added a commit that referenced this issue Feb 16, 2022
@RebeccaStevens
feat: provide customizable meta data to custom merge functions
f6b1cad 
fix #33
github-actions bot pushed a commit that referenced this issue Feb 16, 2022
@semantic-release-bot
chore(release): 3.0.0-beta.5 [skip ci]
1f4fafa 
# [3.0.0-beta.5](v3.0.0-beta.4...v3.0.0-beta.5) (2022-02-16)

### Features

* provide customizable meta data to custom merge functions ([f6b1cad](f6b1cad)), closes [#33](#33)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

RebeccaStevens added a commit that referenced this issue Feb 17, 2022
@RebeccaStevens
feat: provide customizable meta data to custom merge functions
bbcf680 
fix #33
RebeccaStevens added a commit that referenced this issue Feb 17, 2022
@RebeccaStevens
feat: provide customizable meta data to custom merge functions
9831269 
fix #33
RebeccaStevens added a commit that referenced this issue Feb 17, 2022
@RebeccaStevens
feat: provide customizable meta data to custom merge functions
7cae0bf 
fix #33
RebeccaStevens added a commit that referenced this issue Feb 18, 2022
@RebeccaStevens
feat: provide customizable meta data to custom merge functions
e9c5a0e 
fix #33
RebeccaStevens added a commit that referenced this issue Feb 19, 2022
@RebeccaStevens
feat: provide customizable meta data to custom merge functions
9acaecf 
fix #33
github-actions bot pushed a commit that referenced this issue Feb 19, 2022
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
caf57ce 
# [3.0.0](v2.0.1...v3.0.0) (2022-02-19)

### Code Refactoring

* unrequire unused types and values ([c78e373](c78e373))

### Features

* lone values will now be passed to mergeOthers rather than just returned ([#57](#57)) ([9c24584](9c24584))
* provide customizable meta data to custom merge functions ([3d96692](3d96692)), closes [#33](#33)

### BREAKING CHANGES

* some types have changed for `deepmergeCustom`
@github-actions
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Feb 19, 2022
@RebeccaStevens RebeccaStevens linked a pull request Feb 19, 2022 that will close this issue
ci: automatically apply the done label to issues closed by PRs #29
Merged
@RebeccaStevens RebeccaStevens added Resolution: Added This has been added to the project. and removed Status: In Progress Issue is currently being resolved by a developer. labels Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: Added This has been added to the project. Status: Released It's now live. Type: Feature New features or options.
Projects
None yet
Milestone
No milestone
1 participant
@RebeccaStevens