Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support [Module: null prototype] #133

Closed
xuxucode opened this issue Jun 7, 2022 · 2 comments · Fixed by #135
Closed

Please support [Module: null prototype] #133

xuxucode opened this issue Jun 7, 2022 · 2 comments · Fixed by #135
Labels
Accepted This issue or PR has been accepted. Resolution: Added This has been added to the project. Status: Released It's now live. Type: Feature New features or options.

Comments

@xuxucode
Copy link

xuxucode commented Jun 7, 2022

Does not work with imported modules.

For example:

// module-a.js file
export const age = 30;

// module-b.js file
export const name = 'alice';

// deep merge
const a = await import('./module-a.js'); // [Module: null prototype] { age: 30 }
const b = await import('./module-b.js'); // [Module: null prototype] { name: 'alice' }
const merged = deepmerge(a, b);

Actual merge result

{
  name: 'alice'
}

Expected merge result

{
  age: 30,
  name: 'alice'
}
@xuxucode xuxucode added Status: Triage This issue needs to be triaged. Type: Idea Marks an idea, which might be accepted and implemented. labels Jun 7, 2022
@RebeccaStevens RebeccaStevens added Type: Feature New features or options. Accepted This issue or PR has been accepted. and removed Status: Triage This issue needs to be triaged. Type: Idea Marks an idea, which might be accepted and implemented. labels Jun 7, 2022
RebeccaStevens added a commit that referenced this issue Jun 12, 2022
RebeccaStevens added a commit that referenced this issue Jun 12, 2022
RebeccaStevens added a commit that referenced this issue Jun 12, 2022
RebeccaStevens added a commit that referenced this issue Jun 13, 2022
RebeccaStevens added a commit that referenced this issue Jun 13, 2022
@github-actions github-actions bot added the Resolution: Added This has been added to the project. label Jun 13, 2022
github-actions bot pushed a commit that referenced this issue Jun 13, 2022
# [4.1.0](v4.0.4...v4.1.0) (2022-06-13)

### Features

* treat module imports as records ([20c0dfb](20c0dfb)), closes [#133](#133)
@github-actions
Copy link

🎉 This issue has been resolved in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the Status: Released It's now live. label Jun 13, 2022
@xuxucode
Copy link
Author

Thanks, works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted This issue or PR has been accepted. Resolution: Added This has been added to the project. Status: Released It's now live. Type: Feature New features or options.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants