Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move private keys to secrets manager / environment variables. #2

Closed
sudhirj opened this issue Oct 19, 2022 · 0 comments · Fixed by #4
Closed

Move private keys to secrets manager / environment variables. #2

sudhirj opened this issue Oct 19, 2022 · 0 comments · Fixed by #4
Assignees
@ananthb
Labels
enhancement New feature or request

Comments

@sudhirj
Copy link
Member

sudhirj commented Oct 19, 2022

Putting the private key in S3 smells very bad, especially when it's placed right next a cert bundle that's expected to be shared.

Suggest putting the private key in secrets manager, and assuming it'll be preset to the signer as an environment variable. Can also see https://aws.amazon.com/about-aws/whats-new/2022/10/aws-parameters-secrets-lambda-extension/
@ananthb ananthb self-assigned this Nov 29, 2022
@ananthb ananthb linked a pull request Dec 16, 2022 that will close this issue
Support file://, s3://, and ARNs for loading files #4
Merged
@ananthb ananthb added enhancement New feature or request issuer labels Dec 18, 2022
ananthb pushed a commit that referenced this issue Sep 10, 2024
@Vikram-parihar
Dimensions ClientID <-> TheatreID Lookup Plugin (#2)
dae79a3 
* single plugin for both manifest and tdl client

* implemented suggested changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ananthb ananthb

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support file://, s3://, and ARNs for loading files RealImage/bifrost
2 participants
@sudhirj @ananthb