FEATURE: Added option to user can request for ooo status using dev FF #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sahsisunny
changed the title
Achintya-Chatterjee
approved these changes
Mar 26, 2024
Achintya-Chatterjee
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
form-validation.2.mp4
Is Reason not mandatory, it is accepting white spaces.
Can we validate the form on the client side first before sending it to the server, to avoid unnecessary server calls.
And can we also provide a feedback to the user about the errors(both client and server) on the UI.
VinayakaHegade
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number
Description
Implemented a user interface (UI) feature for requesting Out of Office (OOO) status. The UI includes a form with fields for From Date Picker, Until Date Picker, and Message Text Area. Integrated the UI with the backend through a POST API call to /requests?dev=true. Implemented input validation, user feedback, loading indicators, and a feature flag named "dev".
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Demo
request.OOO.mp4
Test Coverage
Skip one test