Make delete() not use unwrap, eliminate clones

ReagentX · Sep 22, 2021 · 0847afc · 0847afc
1 parent fbf1859
commit 0847afc
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/src/util/counter.rs b/src/util/counter.rs
@@ -43,7 +43,6 @@ impl<T: Hash + Eq + PartialEq + Clone + Display> Counter<T> {
             .map(|f| f.to_owned())
             .collect();
         counts.sort_unstable();
-        // panic!("{:?}", counts);
 
         // Get the value under each key
         for count in counts.iter().rev() {
@@ -61,13 +60,13 @@ impl<T: Hash + Eq + PartialEq + Clone + Display> Counter<T> {
     }
 
     /// Remove an item from the internal order store
-    fn purge_from_order(&mut self, item: &T, count: &u64) {
-        if let Some(order) = self.order.get_mut(count) {
+    fn purge_from_order(&mut self, item: &T, count: u64) {
+        if let Some(order) = self.order.get_mut(&count) {
             // If there was data there, remove the existing item
             if !order.is_empty() {
                 order.retain(|i| i != item);
                 if order.is_empty() {
-                    self.order.remove(count);
+                    self.order.remove(&count);
                 }
             };
         };
@@ -79,7 +78,7 @@ impl<T: Hash + Eq + PartialEq + Clone + Display> Counter<T> {
 
     /// Update the internal item order HashMap
     fn update_order(&mut self, item: T, old_count: &u64, new_count: &u64) {
-        self.purge_from_order(&item, old_count);
+        self.purge_from_order(&item, *old_count);
         match self.order.get_mut(new_count) {
             Some(v) => {
                 v.push(item);
@@ -92,7 +91,7 @@ impl<T: Hash + Eq + PartialEq + Clone + Display> Counter<T> {
 
     /// Increment an item into the counter, creating if it does not exist
     fn increment(&mut self, item: T) {
-        let old_count = self.state.get(&item).unwrap_or(&0).to_owned();
+        let old_count = *self.state.get(&item).unwrap_or(&0);
         let new_count = old_count.checked_add(1);
         match new_count {
             Some(count) => self.state.insert(item.to_owned(), count),
@@ -103,7 +102,7 @@ impl<T: Hash + Eq + PartialEq + Clone + Display> Counter<T> {
 
     /// Reduce an item from the counter, removing if it becomes 0
     fn decrement(&mut self, item: T) {
-        let old_count = self.state.get(&item).unwrap_or(&0).to_owned();
+        let old_count = *self.state.get(&item).unwrap_or(&0);
         let new_count = old_count.checked_sub(1);
         match new_count {
             Some(count) => {
@@ -122,10 +121,10 @@ impl<T: Hash + Eq + PartialEq + Clone + Display> Counter<T> {
 
     /// Remove an item from the counter completely
     fn delete(&mut self, item: &T) {
-        // TODO: Make this safe
-        let count = self.state.get(item).unwrap().to_owned();
-        self.purge_from_order(item, &count);
-        self.purge_from_state(item);
+        if let Some(count) = self.state.get(item) {
+            self.purge_from_order(item, *count);
+            self.purge_from_state(item);
+        }
     }
 }