Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dtslint): add mergeMapTo #4097

Merged
merged 2 commits into from
Sep 11, 2018
Merged

test(dtslint): add mergeMapTo #4097

merged 2 commits into from
Sep 11, 2018

Conversation

timdeschryver
Copy link
Contributor

Description:
This PR adds dtslint tests for mergeMapTo.

Related issue (if exists): #4093

@timdeschryver
Copy link
Contributor Author

Would it also be OK to remove unused imports? e.g.:

// mergeMapTo.ts
import { Observable } from '../Observable';

@coveralls
Copy link

coveralls commented Sep 5, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 96.798% when pulling 6b0abb8 on timdeschryver:pr/dtslint-merge-map-to into c89040e on ReactiveX:master.

cartant
cartant approved these changes Sep 8, 2018
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cartant cartant merged commit 25b0d56 into ReactiveX:master Sep 11, 2018
@timdeschryver timdeschryver deleted the pr/dtslint-merge-map-to branch September 12, 2018 06:08
@lock lock bot locked as resolved and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cartant cartant cartant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timdeschryver @coveralls @cartant