-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AjaxObservable): support withCredentials for CORS request #1758
Conversation
Looks like there are some new code branches that are not covered. https://coveralls.io/builds/6534299/source?filename=src%2Fobservable%2Fdom%2FAjaxObservable.ts#L33 |
Yes it is, it was bit tough to cover all cases. I'll try to update them. |
Updated couple of test cases to cover basic scenarios of XHR creation. |
- AjaxRequest now support setting withCredentials flag closes ReactiveX#1732, ReactiveX#1711
I think change's ok, will check in around on this Sunday to next Monday if there isn't any suggestions. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
This PR updates
AjaxRequest
acceptswithCredentials
flag to be used when create CORS request by settingcrossDomain
, replicating RXJS-DOM implementation.Related issue (if exists):
closes #1732, #1711