Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix example on README #712

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix example on README #712

merged 1 commit into from
Apr 5, 2023

Conversation

wurikiji
Copy link
Contributor

The default behavior of the throttle and throttleTime is to emit the leading item of the time window. The implementation is correct, but the example of the README needs to be corrected. The example should print 1, not 3.

hoc081098
hoc081098 approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@hoc081098 hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catching

@hoc081098 hoc081098 merged commit 78f0ced into ReactiveX:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoc081098 hoc081098 hoc081098 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wurikiji @hoc081098