Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(subject): addStream #700

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Conversation

hoc081098
Copy link
Collaborator

No description provided.

@hoc081098 hoc081098 self-assigned this Nov 16, 2022
@hoc081098 hoc081098 changed the title fix(subject/addStream): cancel the StreamSubscription before completing the returned Future fix(subject/addStream): cancel the StreamSubscription before completing the returned Future Nov 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #700 (c26402a) into master (e1f6cd9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files          77       77           
  Lines        2384     2384           
=======================================
  Hits         2216     2216           
  Misses        168      168           

@hoc081098 hoc081098 changed the title fix(subject/addStream): cancel the StreamSubscription before completing the returned Future refactor(subject/addStream) Nov 16, 2022
@hoc081098 hoc081098 changed the title refactor(subject/addStream) refactor(subject): addStream Nov 16, 2022
@hoc081098 hoc081098 merged commit b0d6ad1 into ReactiveX:master Nov 16, 2022
@hoc081098 hoc081098 deleted the rework_addStream branch November 16, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants