Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hierarchy and hierachy bounds listener support #55

Merged
merged 2 commits into from
Aug 27, 2016

Conversation

mikebaum
Copy link
Collaborator

This PR implements issues #32 and #33. There are three commits, the first is just to fix the broken build. That should be reviewed and merged as per issue #54.

@mikebaum
Copy link
Collaborator Author

I included a commit that fixed the broken build, see issue #54. When that's merged, I will rebase this PR on top of the branch 0.x.

@mikebaum mikebaum force-pushed the addHierarchyBoundsListenerSupport branch from 7d410c2 to f84e665 Compare November 7, 2015 23:54
@akarnokd
Copy link
Member

akarnokd commented Aug 9, 2016

Could you rebase this?

@Petikoch
Copy link
Contributor

@mikebaum ,

I reviewed the change today...

  • SwingObservable changes -> fine
  • HierarchyEventSource -> fine. Nice Predicate!
  • HierarchyEventSourceTest and HierarchyBoundsEventSourceTest
    • Testcode -> fine. There are a thousand ways to do it...
    • Coverage for changes -> 100%. Excellent.

I'd say... rebase it, merge it, release it!

Let's give back some life to RxSwing.

Best regards,
Peti

@mikebaum
Copy link
Collaborator Author

@Petikoch Thanks for the review. I'll have to dust this code off, rebase and merge.

Yeah, lets tackle some of the work on this project.... I'm ready to pull up my sleeves.

Mike

@mikebaum mikebaum force-pushed the addHierarchyBoundsListenerSupport branch from f84e665 to f5ef38c Compare August 27, 2016 12:14
@mikebaum mikebaum merged commit 281ddb9 into ReactiveX:0.x Aug 27, 2016
@mikebaum mikebaum deleted the addHierarchyBoundsListenerSupport branch August 27, 2016 12:16
@Petikoch
Copy link
Contributor

Petikoch commented Sep 1, 2016

What about releasing?

Best regards,
Peti

@mikebaum
Copy link
Collaborator Author

@Petikoch Thanks for the reminder. I actually started to do the release and then got busy renovating my house... Anyway, I've been crazy busy with my day job. Gonna take care of this tomorrow...

@mikebaum
Copy link
Collaborator Author

@Petikoch Added release 0.27.0

@Petikoch
Copy link
Contributor

@mikebaum Thanks for releasing! And all the best for the house renovation... :-)

Best regards,
Peti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants