Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DocumentEvent support #22

Merged
merged 3 commits into from
May 14, 2015
Merged

Added DocumentEvent support #22

merged 3 commits into from
May 14, 2015

Conversation

rosvit
Copy link
Contributor

@rosvit rosvit commented May 12, 2015

Hi all, I thought that I could contribute with an implementation for DocumentEvents, which I needed and implemented for one project.

I hope it will be helpful. Thanks!

@epb-644
Copy link
Collaborator

epb-644 commented May 13, 2015

Hey @rosvit, thanks for getting involved. Could you add an subscribeOn(SwingScheduler.getInstance()) call directly after your subscribeOn? (I just merged a pull request to add that call to all the sources.)

@rosvit
Copy link
Contributor Author

rosvit commented May 14, 2015

Thanks @eddieburns55, I have added unsubscribing in EDT for DocumentEventSource.

epb-644 added a commit that referenced this pull request May 14, 2015
@epb-644 epb-644 merged commit 68847d5 into ReactiveX:0.x May 14, 2015
@epb-644 epb-644 mentioned this pull request May 14, 2015
@rosvit rosvit deleted the document-event branch May 14, 2015 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants