from creation function added #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Carlos, There are just some minor tweaks I would want to ask you. Would it be possible to merge all of the commits into one commit? I don't want to spam RxSwift git commit history :) 7 commits for 30 lines seem little too much :) So I would really appreciate if you would just merge all of this into one commit named something like "Adds from conversion function". There is also a typo in source code. Other then that 👍 |
| @@ -56,6 +56,17 @@ public func returnElements<E>(values: E ...) -> Observable<E> { | |||
| } | |||
| } | |||
|
|
|||
| public func from<E, S where S: SequenceType, S.Generator.Element == E>(secuence: S) -> Observable<E> { | |||
There was a problem hiding this comment.
I think it should be "sequence" instead of "secuence". Not a big problem, but we should fix it.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://reactivex.io/documentation/operators/from.html