rxcocoa build fix on xcode 9 #1341
Conversation
| @@ -31,12 +31,12 @@ private class RxPickerViewArrayDataSource<T>: NSObject, UIPickerViewDataSource, | |||
| } | |||
| } | |||
|
|
|||
| private class RxPickerViewSequenceDataSource<S: Sequence> | |||
| public class RxPickerViewSequenceDataSource<S: Sequence> | |||
There was a problem hiding this comment.
Hi @anonymcek ,
I don't think any of these elements should be public.
Can you please try just removing private identifier from RxPickerViewSequenceDataSource and from RxPickerViewArrayDataSource?
There was a problem hiding this comment.
RxPickerViewArrayDataSource can stay private, should I remove it anyway?
There was a problem hiding this comment.
I don't think that anyone understands anymore what is by design and what works by pure accident here so I think it would be safer to also remove private from RxPickerViewArrayDataSource.
|
I wonder if it's because of new I feel like it should work with |
|
it is referenced from I can add |
|
does anyone have a clue what is wrong with that tests? |
|
Hm this is so weird.. Because we do not reference |
I am not sure about other classes and their visibility but the RxPickerViewSequenceDataSource being private doesn't work on XCode 9. Actually I don't understand how it could build at all without being public.