Fix onErrorResumeNext partial function ambiguity problem #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aks partial function usage - onErrorResumeNext(Observable[U]) can be accomplished with onErrorResumeNext(Throwable => Observable[U]) like this o.onErrorResumeNext(_ => resumeSeq)
…rowable => Observable[U])
…th a partial function
|
LGTM. Hold off until 0.24.0. |
zsxwing
added a commit
that referenced
this pull request
Mar 3, 2015
Fix onErrorResumeNext partial function ambiguity problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #79, the current implementation of having two overloaded onErrorResumeNext methods leads to ambiguity problems with the common Scala partial function shorthand idiom. This pull request solves this by removing one of the onErrorResumeNext methods, since the functionality of that method can be accomplished by using the remaining method.