Add missing Subject constructors and Subject classes from RxJava to RxScala #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| subject.subscribe(observer2) | ||
| subject.onNext("three") | ||
| subject.onCompleted() | ||
| </pre> |
There was a problem hiding this comment.
You should not use html tags in scaladoc, because for most of what you want to do, there's a better markdown-like version. For instance, if you use {{{...}}} instead of <pre>...</pre>, you'll get syntax highlighting. The best way to learn scaladoc is imho by example, such as by looking at any class in the Scala standard library.
samuelgruetter
added a commit
that referenced
this pull request
Oct 4, 2014
Add missing Subject constructors and Subject classes from RxJava to RxScala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also copies RxJava JavaDoc to ScalaDoc for each Subject as more visible documentation in Scala.