Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FutureToObservable #222

Merged
merged 1 commit into from
Dec 26, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/main/scala/rx/lang/scala/package.scala
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
*/
package rx.lang

import _root_.scala.util.{Try, Success, Failure}
import _root_.scala.util.Try
import _root_.scala.concurrent.{ExecutionContext, Future}

/**
* This package contains all classes that RxScala users need.
Expand All @@ -24,18 +25,23 @@ import _root_.scala.util.{Try, Success, Failure}
*/
package object scala {

/**
* Placeholder for extension methods into Observable[T] from other types
*/
/** Adds a [[toObservable]] extension method to [[_root_.scala.collection.Iterable Iterable]] */
implicit class ObservableExtensions[T](val source: Iterable[T]) extends AnyVal {
def toObservable: Observable[T] = { Observable.from(source) }
def toObservable: Observable[T] = Observable.from(source)
}

/** Adds a [[toObservable]] extension method to [[_root_.scala.util.Try Try]] */
implicit class TryToObservable[T](val tryT: Try[T]) extends AnyVal {
def toObservable: Observable[T] = Observable.from(tryT)
}

/** Adds a [[toObservable]] extension method to [[_root_.scala.Option Option]] */
implicit class OptionToObservable[T](val opt: Option[T]) extends AnyVal {
def toObservable: Observable[T] = Observable.from(opt)
}

/** Adds a [[toObservable]] extension method to [[_root_.scala.concurrent.Future Future]] */
implicit class FutureToObservable[T](val future: Future[T]) extends AnyVal {
def toObservable(implicit ec: ExecutionContext): Observable[T] = Observable.from(future)
}
}
118 changes: 118 additions & 0 deletions src/test/scala/rx/lang/scala/ScalaTypesConversionsTests.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
package rx.lang.scala

import org.junit.Test
import org.scalatest.junit.JUnitSuite
import rx.lang.scala.observers.TestSubscriber

import scala.concurrent.Future
import scala.util.{Failure, Success, Try}

class ScalaTypesConversionsTests extends JUnitSuite {

@Test
def testIterableConversion() = {
val it = Seq("1", "2", "3")
val observer = TestSubscriber[String]()
it.toObservable.subscribe(observer)

observer.assertValues("1", "2", "3")
observer.assertNoErrors()
observer.assertCompleted()
}

@Test
def testIterableEmptyConversion() = {
val it = List[String]()
val observer = TestSubscriber[String]()
it.toObservable.subscribe(observer)

observer.assertNoValues()
observer.assertNoErrors()
observer.assertCompleted()
}

@Test
def testTrySuccessConversion() = {
val success = Success("abc")
val observer = TestSubscriber[String]()
success.toObservable.subscribe(observer)

observer.assertValue("abc")
observer.assertNoErrors()
observer.assertCompleted()
}

@Test
def testTryFailureConversion() = {
val error = new IllegalArgumentException("test error")
val failure = Failure[String](error)
val observer = TestSubscriber[String]()
failure.toObservable.subscribe(observer)

observer.assertNoValues()
observer.assertError(error)
observer.assertNotCompleted()
}

@Test
def testOptionSomeConversion() = {
val some = Option("abc")
val observer = TestSubscriber[String]()
some.toObservable.subscribe(observer)

observer.assertValue("abc")
observer.assertNoErrors()
observer.assertCompleted()
}

@Test
def testOptionNoneConversion() = {
val some = Option.empty[String]
val observer = TestSubscriber[String]()
some.toObservable.subscribe(observer)

observer.assertNoValues()
observer.assertNoErrors()
observer.assertCompleted()
}

@Test
def testFutureSuccessfulConversion() = {
import scala.concurrent.ExecutionContext.Implicits.global
val fut = Future.successful("abc")
val observer = TestSubscriber[String]()
fut.toObservable.subscribe(observer)

observer.awaitTerminalEvent()
observer.assertValue("abc")
observer.assertNoErrors()
observer.assertCompleted()
}

@Test
def testFutureSuccessfulConversion2() = {
import scala.concurrent.ExecutionContext.Implicits.global
val fut = Future { "abc" }
val observer = TestSubscriber[String]()
fut.toObservable.subscribe(observer)

observer.awaitTerminalEvent()
observer.assertValue("abc")
observer.assertNoErrors()
observer.assertCompleted()
}

@Test
def testFutureFailedConversion() = {
import scala.concurrent.ExecutionContext.Implicits.global
val error = new IllegalArgumentException("test error")
val fut = Future.failed[Unit](error)
val observer = TestSubscriber[Unit]()
fut.toObservable.subscribe(observer)

observer.awaitTerminalEvent()
observer.assertNoValues()
observer.assertError(error)
observer.assertNotCompleted()
}
}
55 changes: 0 additions & 55 deletions src/test/scala/rx/lang/scala/TryOptionConversionsTests.scala

This file was deleted.