Upgrade to RxJava 1.0.17 #182
Conversation
| @@ -76,6 +76,8 @@ class ObservableCompletenessKit extends CompletenessKit { | |||
| "doOnUnsubscribe(Action0)" -> "doOnUnsubscribe(=> Unit)", | |||
| "doOnTerminate(Action0)" -> "doOnTerminate(=> Unit)", | |||
| "elementAtOrDefault(Int, T)" -> "elementAtOrDefault(Int, U)", | |||
| "extend(Func1[_ >: OnSubscribe[T], _ <: R])" -> "[TODO]", | |||
| "fromCallable(Callable[_ <: T])" -> "[TODO]", | |||
There was a problem hiding this comment.
Any better name in Scala instead of fromCallable?
There was a problem hiding this comment.
Can't we just use Observable.defer(Observable.just(expensiveComputation))? If yes, can you add an example for this to RxScalaDemo?
There was a problem hiding this comment.
It works as well. Agree that we don't need to add a new method for it.
| @@ -2,7 +2,7 @@ language: scala | |||
| jdk: | |||
| - oraclejdk7 | |||
| script: | |||
| - sbt +test +examples/test | |||
| - sbt +test +examples/test +doc | |||
There was a problem hiding this comment.
Also add doc to the build script so that we can test it for PRs
|
@samuelgruetter could you take a look? |
| f(t1).asJavaObservable | ||
| } | ||
| }, capacityHint)) | ||
| } |
There was a problem hiding this comment.
In def flatMap[R](maxConcurrent: Int, f: T => Observable[R]): Observable[R], we have the integer as the first argument, and the function as the second argument. Any reason why to do it differently here? And do you know why they put the function first in RxJava?
There was a problem hiding this comment.
Just forgot we moved maxConcurrent as the first parameter in #166. Will updated it.
And do you know why they put the function first in RxJava?
I guess it just followed the signature in Rx .Net (https://msdn.microsoft.com/en-us/library/hh229923(v=vs.103).aspx)
|
Updated |
|
LGTM, thanks a lot @zsxwing :) |
No description provided.