Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail the build if CompletenessTest is not happy #36

Closed
samuelgruetter opened this issue Oct 8, 2014 · 1 comment · Fixed by #45
Closed

Fail the build if CompletenessTest is not happy #36

samuelgruetter opened this issue Oct 8, 2014 · 1 comment · Fixed by #45

Comments

@samuelgruetter
Copy link
Collaborator

The CompletenessTest ensures that:

  • all methods of the Java Observable have a corresponding method in the Scala Observable, or a comment on why they don't
  • all Scala methods mentioned in the test actually exist
  • all Java methods mentioned in the test actually exist

If any of these fails, it prints some warnings. However, now that RxScala has its own build, CompletenessTest should fail the build if it isn't happy.
@samuelgruetter samuelgruetter mentioned this issue Oct 8, 2014
Closed
@jbripley
Copy link
Contributor

jbripley commented Oct 8, 2014

I could take a look at this one.

jbripley pushed a commit to jbripley/RxScala that referenced this issue Oct 9, 2014
@jbripley
Removes methods that also have a Scheduler parameter version by addin…
93196c6 
…g a default Scheduler

- Changes some methods to require parentheses (timestamp, timeInterval)

- Make CompletenessTest fail unit tests

Fixes ReactiveX#40 and ReactiveX#36
@jbripley jbripley mentioned this issue Oct 9, 2014
Closed
jbripley pushed a commit to jbripley/RxScala that referenced this issue Oct 11, 2014
@jbripley
Removes methods that also have a Scheduler parameter version by addin…
a0cd085 
…g a default Scheduler

- Changes some methods to require parentheses (timestamp, timeInterval)

- Make CompletenessTest fail unit tests

Fixes ReactiveX#40 and ReactiveX#36
@jbripley jbripley mentioned this issue Oct 12, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail build if not all RxJava methods are mapped to a RxScala equivalent jbripley/RxScala
2 participants
@jbripley @samuelgruetter