Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace => Unit by () => Unit #225

Closed
samuelgruetter opened this issue Jan 16, 2017 · 2 comments
Closed

replace => Unit by () => Unit #225

samuelgruetter opened this issue Jan 16, 2017 · 2 comments

Comments

@samuelgruetter
Copy link
Collaborator

I suggest that we replace all => Unit arguments by () => Unit.
See #175 for more discussion/explanation.
This would affect the following methods (provided that I didn't miss any 😉):

  • doAfterTerminate
  • doOnTerminate
  • doOnCompleted
  • doOnSubscribe
  • doOnUnsubscribe
  • onBackpressureBuffer
@samuelgruetter samuelgruetter mentioned this issue Jan 16, 2017
Closed
@zsxwing
Copy link
Member

zsxwing commented Jan 16, 2017

Sounds good to me

dhoepelman pushed a commit to dhoepelman/RxScala that referenced this issue May 12, 2017
Change => Unit callbacks to () => Unit (Fixes ReactiveX#225 rever…
00781db 
…ts RxJava/#1345)
@dhoepelman dhoepelman mentioned this issue May 12, 2017
Closed
dhoepelman pushed a commit to dhoepelman/RxScala that referenced this issue May 12, 2017
Change => Unit callbacks to () => Unit (Fixes ReactiveX#225 rever…
de4524a 
…ts RxJava/#1345)
dhoepelman pushed a commit to dhoepelman/RxScala that referenced this issue May 12, 2017
Change => Unit callbacks to () => Unit (Fixes ReactiveX#225 rever…
8d42113 
…ts RxJava/#1345)
@dhoepelman
Copy link
Collaborator

Due to project EOL status, this change will not be made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhoepelman @zsxwing @samuelgruetter