Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.24 #147

Closed
benjchristensen opened this issue Mar 3, 2015 · 15 comments
Closed

v0.24 #147

benjchristensen opened this issue Mar 3, 2015 · 15 comments

Comments

@benjchristensen
Copy link
Member

Is 0.24 ready to release? We need the new takeUntil overload.

cc @bpitman

@zsxwing
Copy link
Member

zsxwing commented Mar 3, 2015

I added it in pr #146
We're looking for a best approach to add the experimental APIs.

@benjchristensen
Copy link
Member Author

No annotations or other such mechanisms for marking APIs in scala?

If not that, then just Scaladocs?

@zsxwing
Copy link
Member

zsxwing commented Mar 4, 2015

The experimental APIs(methods) of RxJava Observable will be extension methods in RxScala, and needs to be imported explicitly. E.g.,

    import rx.lang.scala.ExperimentalAPIs._

    Observable.just(1, 2, 3, 4, 5, 6, 7).
      doOnNext(v => println(s"onNext: $v")).
      takeUntil((x: Int) => x == 3). 
      foreach(println)

However, for the experimental classes, such as AbstractOnSubscribe, I would like to use @Beta/@experimental annotations. What do you think?

@benjchristensen
Copy link
Member Author

benjchristensen commented Mar 4, 2015 via email

@zsxwing
Copy link
Member

zsxwing commented Mar 5, 2015

Just wrote a release note for 0.24.0 #148

@zsxwing
Copy link
Member

zsxwing commented Mar 6, 2015

@benjchristensen I just released 0.24.0. However, Bintray cannot sync the files to Sonatype automatically. Could you help sync them?

I found an API of Bintray here: https://bintray.com/docs/api/#_sync_version_artifacts_to_maven_central
It requires the username and password of Sonatype.

{
  "username": "userToken", // Sonatype OSS user token
  "password": "passwordToken", // Sonatype OSS user password
  "close": "1" // Optional
}

The bintray-sbt plugin uses it to sync files. Could you put them into .travis.yml as secure environments? I will try it to make the bintray-sbt plugin do the synchronization.

@benjchristensen
Copy link
Member Author

Bintray should do all of that automatically. It saves it. For example, on the Gradle builds we don't need those credentials.

@benjchristensen
Copy link
Member Author

Manually synced.

@zsxwing
Copy link
Member

zsxwing commented Mar 8, 2015

Thanks @benjchristensen

But I think Bintray doesn't do it automatically. nebula-bintray-plugin syncs the files. See https://github.com/nebula-plugins/nebula-bintray-plugin/blob/15af24355cc4816c25034b4cf234071fa4497346/src/main/groovy/nebula/plugin/bintray/NebulaBintraySyncPublishingPlugin.groovy It calls the API I mentioned previously.

There is a log in this plugin: logger.info("Package Sync: $uploadUri"). Could you verify it in the CloudBees log? I think RxJava is still published by CloudBees, right?

@benjchristensen
Copy link
Member Author

RxJava is published via Travis and no longer uses CloudBees. I noticed I have to manually sync bintray on that as well so we need to figure out what is missing.

@quidryan What is missing in our publishing process to trigger the Bintray->MavenCentral sync?

@quidryan
Copy link
Collaborator

The sonatype credentials weren't being provided to Gradle in the shell script. @rspieldenner is working on adding them.

@zsxwing
Copy link
Member

zsxwing commented Mar 18, 2015

@benjchristensen could you add sonatypeUsername and sonatypePassword for RxScala?

@rspieldenner
Copy link
Contributor

I'll do that today

On Wed, Mar 18, 2015 at 10:14 AM, Shixiong Zhu [email protected]
wrote:

@benjchristensen https://github.com/benjchristensen could you add
sonatypeUsername and sonatypePassword for RxScala?


Reply to this email directly or view it on GitHub
#147 (comment).

@zsxwing
Copy link
Member

zsxwing commented Mar 19, 2015

The names of the environment variables should be SONA_USER and SONA_PASS.

@zsxwing
Copy link
Member

zsxwing commented Mar 23, 2015

Closing. I updated the publish script. Will test it when publishing the next release.

@zsxwing zsxwing closed this as completed Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants