SchedulerBase polish, typings, test

[erikkemperman]

I am once again trying to separate moderately sized bits off a branch with way too many changes in it...

[coveralls]

Coverage increased (+0.1%) to 90.319% when pulling 6b1a628 on erikkemperman:scheduler-base into be24259 on ReactiveX:master.

[jcafhe]

I'm just curious, is it worth to re-declare schedule, schedule_relative & schedule_absolute as abstract methods while these are already declared in typing.Scheduler ?

[erikkemperman]

Yeah, maybe not strictly necessary... Although it might help to keep the generated docs and help() complete.

I guess I included this mainly because of an idea I have that I’m playing around with, which would simplify all of the classes that extend SchedulerBase by putting some often-repeated logic (schedule methods being defined in terms of one another) in the base class.

Having these here at this point would make that second step a lot easier / readable.

[jcafhe]

cool 👍

[erikkemperman]

Ugh I just noticed I accidentally included a change in virtualtime scheduler here... It should have been in that other PR.

Sorry about that, I’ve been juggling branches and commits and this fell through. Please ignore that part, I’ll transplant it later.

[erikkemperman]

FYI, I removed the bit which was not supposed to be in this PR, and I added a sentence about to_timedelta being relative to the epoch (1970-01-01) as suggested by @jcafhe

[dbrattli]

Nice work!

[erikkemperman]

Thanks for review!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.