Fixes #237 (Empty ByteBuf leak) #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was not sending an `onNext` call for empty buffers. This resulted in leaking memory for empty payload responses as the release of `ByteBuf` was a part of the `onNext` call. This change sends the content `onNext` unconditionally and lets the user decide what to do with the buffer.
NiteshKant
added a commit
that referenced
this pull request
Oct 16, 2014
Fixes #237 (Empty ByteBuf leak)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was not sending an
onNextcall for empty buffers.This resulted in leaking memory for empty payload responses as the release of
ByteBufwas a part of theonNextcall.This change sends the content
onNextunconditionally and lets the user decide what to do with the buffer.