Fixes #195 #197
Merged
Fixes #195 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 31, 2014 14:50
RxClient.shutdown() was shutting down the eventloop. This caused the following scenario impossible to work: 1) Create some clients 2) Shutdown all of them 3) Create another client & try to use it. In the above scenario, at stage 3, the eventloop is shutdown and hence can not be used by the newly created client. Removing the eventloop shutdown. Since, the eventloop is always a daemon, shutting it down isn't really necessary. We will think about graceful JVM shutdown scenarios and hence a need to provide a global shutdown on RxNetty later.
|
RxNetty-pull-requests #124 FAILURE |
|
RxNetty-pull-requests #125 FAILURE |
|
RxNetty-pull-requests #126 SUCCESS |
NiteshKant
added a commit
that referenced
this pull request
Aug 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RxClient.shutdown() was shutting down the eventloop.
This caused the following scenario impossible to work:
In the above scenario, at stage 3, the eventloop is shutdown and hence can not be used by the newly created client.
Removing the eventloop shutdown. Since, the eventloop is always a daemon, shutting it down isn't really necessary.
We will think about graceful JVM shutdown scenarios and hence a need to provide a global shutdown on RxNetty later.