Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rx-netty/examples build. #138

Closed
wants to merge 2 commits into from
Closed

Fix rx-netty/examples build. #138

wants to merge 2 commits into from

Conversation

tbak
Copy link
Collaborator

@tbak tbak commented Jun 10, 2014

No description provided.

@cloudbees-pull-request-builder
Copy link

RxNetty-pull-requests #67 SUCCESS
This pull request looks good

Move examples from rx-netty/src/examples to own top level project.
059c39c 
Given the need to write some unit tests for the examples, this will
make the build setup more explicite (versus now being custom
configuration of rx-netty project).
@cloudbees-pull-request-builder
Copy link

RxNetty-pull-requests #68 SUCCESS
This pull request looks good

@NiteshKant
Copy link
Member

Does this also publish examples as an artifact to maven?
I would prefer the entire examples revamp (issue #127 ) as a single PR over the incremental changes. Do you want your incremental changes to be merged?

@NiteshKant
Copy link
Member

Discussed offline with @tbak. He will send a different PR with the comprehensive changes for issue #127. Closing this PR.

@NiteshKant NiteshKant closed this Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbak @cloudbees-pull-request-builder @NiteshKant