Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue #126 #128

Merged
merged 3 commits into from
May 29, 2014
Merged

Fixes issue #126 #128

merged 3 commits into from
May 29, 2014

Conversation

NiteshKant
Copy link
Member

HttpServer now handles HTTP 1.0 requests as per the spec.

Fixes issue ReactiveX#126
be72f7f 
HttpServer now handles HTTP 1.0 requests as per the spec.
@cloudbees-pull-request-builder
Copy link

RxNetty-pull-requests #52 ABORTED

Fix for issue ReactiveX#126 was wrong.
5f5c12f 
HttpServerResponse.close() was asserting the transfer encoding to add LastHttpContent.
The transfer encoding was getting added in ServerRequestResponseConverter.
In cases, when close() is NOT invoked from the eventloop of the server, there is a race-condition
between when the transfer encoding is updated (in the handler) and when close() asserts the same as
the handler is invoked in a different thread (server eventloop) than close()

Also added some testcases for this scneario.

Bug fix
@cloudbees-pull-request-builder
Copy link

RxNetty-pull-requests #53 FAILURE
Looks like there's a problem with this pull request

@NiteshKant
Copy link
Member Author

RxNetty-pull-requests #53 FAILURE
Looks like there's a problem with this pull request

Strange that the build failed due to maven not reachable.

* What went wrong:
Could not resolve all dependencies for configuration ':rx-netty:testCompile'.
> Could not resolve junit:junit:4.10.
  Required by:
      com.netflix.rxnetty:rx-netty:0.3.6
   > Could not GET 'http://repo1.maven.org/maven2/junit/junit/4.10/junit-4.10.pom'.
      > No route to host

Making the rfc 2145 compliance optional.
dfe71af 
http://tools.ietf.org/html/rfc2145#section-2.3 says that a HTTP 1.1 compliant server should always send a 1.1 response.
However, some clients (apache bench) can not gracefully handle 1.1 responses. Thus making this optional on the HTTPServerBuilder.
@cloudbees-pull-request-builder
Copy link

RxNetty-pull-requests #54 SUCCESS
This pull request looks good

NiteshKant added a commit that referenced this pull request May 29, 2014
@NiteshKant
Merge pull request #128 from NiteshKant/master
c1d0476 
Fixes issue #126
@NiteshKant NiteshKant merged commit c1d0476 into ReactiveX:master May 29, 2014
@NiteshKant NiteshKant mentioned this pull request May 31, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiteshKant @cloudbees-pull-request-builder