Remove ContentSource in favor of Observable for HttpClientRequest #169
Milestone
Comments
NiteshKant
pushed a commit
to NiteshKant/RxNetty
that referenced
this issue
Jul 4, 2014
- Modified HttpClientRequest to take an Observable for content instead of the earlier ContentSource. - Retained the capability to use an Observable<S> where S != type of the HttpClientRequest. This mode requires passing a function that converts S to ByteBuf. - Removed the RepeatableRequest functionality as it is not required. Re-subscribing to the content observable should replay the source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
HttpClientRequestdoes not useObservablesource for its content. The intent of this was to retain the ability to put back pressure when the need arises.Since, an
Observablesource did not initially provide a way to put back pressure, this approach was chosen initially.RxJava is going to provide back pressure support with the regular
Observableas discussed in this issue. This is a more flexible solution (specifically when the source is actually an Observable, eg: for proxies) than the currentContentSourceabstraction.Since, the back pressure support in RxJava can be used with regular
Observablesit is safe now to replaceContentSourcewithObservableand later adopt back pressure in rxnetty.The text was updated successfully, but these errors were encountered: