Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servo listeners do not register themselves to servo #155

Closed
NiteshKant opened this issue Jun 30, 2014 · 0 comments
Closed

Servo listeners do not register themselves to servo #155

NiteshKant opened this issue Jun 30, 2014 · 0 comments
Labels
Milestone

Comments

@NiteshKant
Copy link
Member

RefCountingMonitor is used to register the servo monitors with servo, however, instead of registering the monitor instance with servo, RefCountingMonitor registers itself:

source

 public void onSubscribe() {
        if (subscriptionCount.incrementAndGet() == 0) {
            ServoUtils.registerObject(monitorId, this);
        }
    }

Instead, it should take the object to be registered with servo.

@NiteshKant NiteshKant added this to the 0.3.7 milestone Jun 30, 2014
@NiteshKant NiteshKant added the bug label Jun 30, 2014
@NiteshKant NiteshKant self-assigned this Jun 30, 2014
NiteshKant pushed a commit to NiteshKant/RxNetty that referenced this issue Jun 30, 2014
ReactiveX#155: Register actual monitor objects with servo.
ReactiveX#156 Total request processing time for HTTP client.
NiteshKant added a commit that referenced this issue Jun 30, 2014
@NiteshKant NiteshKant removed their assignment Aug 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant