-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS Support #106
Comments
Netty supports SSL via SSLHandler so RxNetty also does support SSL. You can create a PipelineConfigurator implementation that adds an SSLHandler in the pipeline much as this example in netty demonstrates. In order to understand RxNetty's PipelineConfigurators have a look at the pipeline package Having said the above, I think we should add an HTTPs example. I will add the same. |
To add SSL/TLS support to RxNetty, the RxServer/RxClient pipeline setup must be made more flexible. SSL handling is supported by Netty's SslHandler ChannelHandler. It enforces a three step process for full communication setup:
The first two steps can be done easily now. What is less obvious is how to prevent ObservableConnection from firing write events into the channel prior to getting handshake confirmation event. Having said that here is a working prototype for TCP protocol without waiting for handshake complete event: tbak@4c55b21 Any read or write to the channel will enforce handshake negotiation in a first place. I am not sure if we can rely on it, or strictly follow the rules written in SslHandler documentation. |
First version with proper handling of the handshake event is available here: https://github.com/tbak/RxNetty/commits/features/ssl |
This reverts commit f71f24e.
SSL support is now implemented. Most of the changes are in this commit: 07c39de. |
Hello,
Does RxNetty Http client can connect to https websites ? I do not see any doc or sample relating to https.
Thank you!
The text was updated successfully, but these errors were encountered: