Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Fix experimental, signatures of throttleLast #7490

Merged
merged 3 commits into from
Dec 4, 2022

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 3, 2022

  • Add experimental annotations
  • Fix Observable.sample wrong overload
  • Fix contravariance on the onDropped consumer.

@akarnokd akarnokd added this to the 3.1-support milestone Dec 3, 2022
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #7490 (ae560d8) into 3.x (1104c09) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.x    #7490      +/-   ##
============================================
- Coverage     99.53%   99.51%   -0.02%     
  Complexity     6792     6792              
============================================
  Files           752      752              
  Lines         47646    47646              
  Branches       6398     6398              
============================================
- Hits          47423    47416       -7     
- Misses          101      108       +7     
  Partials        122      122              
Impacted Files Coverage Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <100.00%> (ø)
...ternal/operators/flowable/FlowableSampleTimed.java 100.00% <100.00%> (ø)
...al/operators/observable/ObservableSampleTimed.java 100.00% <100.00%> (ø)
...x/rxjava3/internal/operators/single/SingleAmb.java 96.61% <0.00%> (-3.39%) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.30% <0.00%> (-2.60%) ⬇️
...eactivex/rxjava3/processors/BehaviorProcessor.java 97.48% <0.00%> (-2.52%) ⬇️
...o/reactivex/rxjava3/processors/AsyncProcessor.java 97.91% <0.00%> (-2.09%) ⬇️
...va3/internal/operators/parallel/ParallelRunOn.java 98.53% <0.00%> (-1.47%) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 95.07% <0.00%> (-1.41%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akarnokd akarnokd merged commit 5b3510b into ReactiveX:3.x Dec 4, 2022
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants