Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearly document side effects of calling Schedulers.from() #7300

Closed
wants to merge 1 commit into from
Closed

Clearly document side effects of calling Schedulers.from() #7300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/main/java/io/reactivex/rxjava3/schedulers/Schedulers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,8 @@ public static Scheduler single() {
* execute those tasks "unexpectedly".
* <p>
* Note that this method returns a new {@code Scheduler} instance, even for the same {@code Executor} instance.
* Calling this method will have the side effect of instantiating all the default RxJava Schedulers,
* if they have not already been instantiated.
* @param executor
* the executor to wrap
* @return the new {@code Scheduler} wrapping the {@code Executor}
Expand Down Expand Up @@ -450,6 +452,8 @@ public static Scheduler from(@NonNull Executor executor) {
* execute those tasks "unexpectedly".
* <p>
* Note that this method returns a new {@code Scheduler} instance, even for the same {@code Executor} instance.
* Calling this method will have the side effect of instantiating all the default RxJava Schedulers,
* if they have not already been instantiated.
* <p>History: 2.2.6 - experimental
* @param executor
* the executor to wrap
Expand Down Expand Up @@ -530,6 +534,8 @@ public static Scheduler from(@NonNull Executor executor, boolean interruptibleWo
* execute those tasks "unexpectedly".
* <p>
* Note that this method returns a new {@code Scheduler} instance, even for the same {@code Executor} instance.
* Calling this method will have the side effect of instantiating all the default RxJava Schedulers,
* if they have not already been instantiated.
* @param executor
* the executor to wrap
* @param interruptibleWorker if {@code true} the tasks submitted to the {@link io.reactivex.rxjava3.core.Scheduler.Worker Scheduler.Worker} will
Expand Down