Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: CompositeException.printStackTrace to write directly into PrintStream/PrintWriter #7212

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

akarnokd
Copy link
Member

I don't remember why the stacktrace it wasn't printed directly via the PrintStream/PrintWriter; no reason to aggregate the entire string output.

Fixes: #7211

@akarnokd akarnokd added this to the 3.1 milestone Mar 12, 2021
@akarnokd akarnokd changed the title 3.x: CompositeException.printStackTrace to write directly into PS/PW 3.x: CompositeException.printStackTrace to write directly into PrintStream/PrintWriter Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #7212 (993e815) into 3.x (5c0ca03) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7212      +/-   ##
============================================
- Coverage     99.54%   99.49%   -0.05%     
+ Complexity     6759     6756       -3     
============================================
  Files           747      747              
  Lines         47392    47391       -1     
  Branches       6382     6382              
============================================
- Hits          47178    47154      -24     
- Misses           96      109      +13     
- Partials        118      128      +10     
Impacted Files Coverage Δ Complexity Δ
...activex/rxjava3/exceptions/CompositeException.java 100.00% <100.00%> (ø) 35.00 <6.00> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0.00%> (-4.66%) 10.00% <0.00%> (-1.00%)
...l/operators/observable/ObservableFlatMapMaybe.java 94.36% <0.00%> (-2.82%) 2.00% <0.00%> (ø%)
...a/io/reactivex/rxjava3/subjects/SingleSubject.java 97.53% <0.00%> (-2.47%) 37.00% <0.00%> (-1.00%)
...ternal/operators/observable/ObservablePublish.java 97.29% <0.00%> (-1.81%) 16.00% <0.00%> (-1.00%)
.../operators/observable/ObservableFlatMapSingle.java 95.23% <0.00%> (-1.59%) 2.00% <0.00%> (ø%)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 94.81% <0.00%> (-1.56%) 2.00% <0.00%> (ø%)
...vable/ObservableFlatMapCompletableCompletable.java 98.48% <0.00%> (-1.52%) 3.00% <0.00%> (ø%)
...ators/observable/ObservableFlatMapCompletable.java 98.52% <0.00%> (-1.48%) 2.00% <0.00%> (ø%)
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-1.36%) 2.00% <0.00%> (ø%)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c0ca03...993e815. Read the comment docs.

@akarnokd akarnokd merged commit e600b53 into ReactiveX:3.x Mar 12, 2021
@akarnokd akarnokd deleted the CompositeExceptionMemoryReduction branch March 12, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompositeException.printStackTrace vulnerable to OOM when there are too many exceptions wrapped.
2 participants