3.x Fix NPE when debouncing empty source #6559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Related issue #6558
Debounce with selector on the empty
Observable
leads to NPE.It happens because of
DebounceObserver#debouncer
field is set up only whenonNext
is called. WhenonNext
isn't called at all, like when debouncingObservable.empty()
, we get a null reference fromdebouncer
and callemit
onnull
which actually leads to NPE.Change
Wrap
emit
call with null check both inObservableDebounce
andFlowableDebounce
Test plan
To check
Observable
:To check
Flowable
: