Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operators: AsObservable, GroupBy w/ maxGroups, GroupByUntil w/ maxGroups #641

Closed
wants to merge 1 commit into from
Closed

Operators: AsObservable, GroupBy w/ maxGroups, GroupByUntil w/ maxGroups #641

wants to merge 1 commit into from

Conversation

akarnokd
Copy link
Member

Issue #634

Implemented both maxGroups variants on top of (my) groupByUntil so it won't conflict with any potentially rewritten groupBy.

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #569 SUCCESS
This pull request looks good

@zsxwing zsxwing mentioned this pull request Dec 20, 2013
Closed
53 tasks
@benjchristensen
Copy link
Member

While reviewing we (@headinthebox and I) see the maxGroups stuff and don't see matching behavior in Rx.Net.

Can you explain what is being added beyond Rx.Net and why?

While at it can you please separate out asObservable and groupByUntil?

@akarnokd
Copy link
Member Author

Mentioned here and code is here. The overload is there to limit the total number of active groups.

I'll split the ops into two PRs.

@akarnokd akarnokd mentioned this pull request Dec 23, 2013
Merged
@akarnokd akarnokd closed this Dec 23, 2013
@akarnokd akarnokd mentioned this pull request Dec 23, 2013
Closed
@akarnokd akarnokd deleted the OperationAsObsGroupByNUntilOvrld branch January 13, 2014 09:58
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@hexmind @RobWin
add overview and patterns to readme (ReactiveX#641)
41a816b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akarnokd @cloudbees-pull-request-builder @benjchristensen