Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Add concatArrayEagerDelayError operator (expose feature) #6143

Merged
merged 2 commits into from
Aug 7, 2018

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Aug 6, 2018

This PR exposes the existing delayError capability of the concatMapEager operator as concatArrayEagerDelayError for both Flowable and Observable.

In addition, the concatArrayEager and these new methods receive marble diagrams:

Observable

image
image
image
image

Flowable

image
image
image
image

Resolves: #6082

(Sidenote: one of the validators had to be adjusted due to false positive it produced.)

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #6143 into 2.x will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6143      +/-   ##
============================================
- Coverage     98.26%   98.25%   -0.02%     
- Complexity     6191     6192       +1     
============================================
  Files           667      667              
  Lines         44853    44857       +4     
  Branches       6213     6213              
============================================
- Hits          44077    44074       -3     
- Misses          239      241       +2     
- Partials        537      542       +5
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <100%> (ø) 566 <2> (+2) ⬆️
src/main/java/io/reactivex/Observable.java 100% <100%> (ø) 541 <2> (+2) ⬆️
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...reactivex/internal/operators/single/SingleAmb.java 96.36% <0%> (-3.64%) 9% <0%> (-1%)
...a/io/reactivex/internal/util/QueueDrainHelper.java 95.83% <0%> (-2.78%) 55% <0%> (-2%)
...l/operators/observable/ObservableFlatMapMaybe.java 90.84% <0%> (-2.62%) 2% <0%> (ø)
.../internal/disposables/ListCompositeDisposable.java 98% <0%> (-2%) 34% <0%> (-1%)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-1.64%) 2% <0%> (ø)
.../operators/mixed/FlowableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3562dfc...34b88a4. Read the comment docs.

Copy link
Contributor

@artem-zinnatullin artem-zinnatullin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@akarnokd akarnokd merged commit 1ad606b into ReactiveX:2.x Aug 7, 2018
@akarnokd akarnokd deleted the ConcatArrayEagerDelayError branch August 7, 2018 06:57
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants