Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing javadoc's code example of Observable#lift. #6104

Merged
merged 1 commit into from
Jul 22, 2018
Merged

Conversation

lcybo
Copy link
Contributor

@lcybo lcybo commented Jul 22, 2018

Code example in javadoc for Observable#lift seems not compilable in 2.x.
Also, parameter name of ObservableOperator#apply should be downstream I think.

@codecov
Copy link

codecov bot commented Jul 22, 2018

Codecov Report

Merging #6104 into 2.x will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6104      +/-   ##
============================================
- Coverage     98.29%   98.29%   -0.01%     
+ Complexity     6198     6195       -3     
============================================
  Files           667      667              
  Lines         44862    44862              
  Branches       6213     6213              
============================================
- Hits          44097    44096       -1     
- Misses          228      229       +1     
  Partials        537      537
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 539 <0> (ø) ⬇️
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...internal/operators/completable/CompletableAmb.java 96.61% <0%> (-3.39%) 10% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...io/reactivex/subscribers/SerializedSubscriber.java 98.86% <0%> (-1.14%) 26% <0%> (-1%)
...ernal/operators/flowable/FlowableFromIterable.java 95.18% <0%> (-1.07%) 5% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 95.21% <0%> (-1.07%) 3% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...ternal/operators/observable/ObservableFlatMap.java 86.9% <0%> (-0.96%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a42a2...1a94de5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants