Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x: Several more Completable marbles (7/19b) #6098

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

akarnokd
Copy link
Member

This PR adds a couple of more marble diagrams to Completable (#5789):

subscribeOn

image

unsubscribeOn

image

toSingle, toSingleDefault

image
image

toFlowable

image

toMaybe

image

@akarnokd akarnokd added this to the 2.2 milestone Jul 19, 2018
@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #6098 into 2.x will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6098      +/-   ##
============================================
- Coverage     98.27%   98.25%   -0.03%     
- Complexity     6194     6197       +3     
============================================
  Files           667      667              
  Lines         44862    44862              
  Branches       6213     6213              
============================================
- Hits          44087    44078       -9     
- Misses          232      234       +2     
- Partials        543      550       +7
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Completable.java 100% <ø> (ø) 117 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 89.54% <0%> (-5.89%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 90.33% <0%> (-3.87%) 2% <0%> (ø)
...ernal/operators/flowable/FlowableFromIterable.java 94.11% <0%> (-3.21%) 5% <0%> (ø)
.../io/reactivex/internal/schedulers/IoScheduler.java 89.24% <0%> (-2.16%) 9% <0%> (ø)
...ternal/operators/completable/CompletableMerge.java 96.42% <0%> (-1.2%) 2% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableTimeoutTimed.java 98.37% <0%> (-0.82%) 3% <0%> (ø)
...a/io/reactivex/internal/util/QueueDrainHelper.java 97.22% <0%> (-0.7%) 56% <0%> (ø)
...vex/internal/operators/flowable/FlowableCache.java 97.94% <0%> (-0.69%) 10% <0%> (-1%)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b97408...f0b83c7. Read the comment docs.

@akarnokd akarnokd merged commit a80b657 into ReactiveX:2.x Jul 19, 2018
@akarnokd akarnokd deleted the CompletableMarbles0719b branch July 19, 2018 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants