-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marble diagram for Single.hide operator #6077
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #6077 +/- ##
============================================
+ Coverage 98.26% 98.26% +<.01%
Complexity 6192 6192
============================================
Files 666 666
Lines 44806 44806
Branches 6206 6206
============================================
+ Hits 44028 44029 +1
- Misses 236 237 +1
+ Partials 542 540 -2
Continue to review full report at Codecov.
|
@@ -1875,6 +1875,8 @@ | |||
/** | |||
* Hides the identity of the current Single, including the Disposable that is sent | |||
* to the downstream via {@code onSubscribe()}. | |||
* <p> | |||
* <img width="640" height="470" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/Hide.png" alt=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a different superhero(ine) per reactive type who is relatively recognizable from the stylized head and doesn't require complicated drawings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one suitable?
https://github.com/UMFsimke/RxJava/blob/Images/Images/Hide2.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated
I dont get it, why is CI failing. I've run tests locally and I dont get that error which CI is reporting. |
Sometimes CI is a bit noisy and some of our millisecond-level tests can fail. I've restarted the build. |
This should complete
hide
operator in #5788Please let me know if I need to change anything on the diagram itself. If not, please send me URL when you upload image within the project so I can change URL for the marble in the PR.
Although I wasn't sure if I should represent somehow that
Disposable
is hidden as well. If so, can you please tell me how to represent that on marble?